Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[trezor] initial trezor support #1547

Merged
merged 13 commits into from
Dec 3, 2018
Merged

[trezor] initial trezor support #1547

merged 13 commits into from
Dec 3, 2018

Conversation

matheusd
Copy link
Member

@matheusd matheusd commented Jul 24, 2018 •
edited
Loading

Part of #1491

This is meant to be the first trezor related PR. This will not support staking for the moment, only wallet creation, transaction and message signing.

Checklist for things still missing:

@matheusd matheusd force-pushed the trezor branch 2 times, most recently from 5fc980e to 47d5f19 Compare October 10, 2018 13:55
@matheusd matheusd mentioned this pull request Oct 19, 2018
Open
21 tasks
@matheusd matheusd force-pushed the trezor branch 8 times, most recently from d7b1580 to 1c94326 Compare October 30, 2018 19:49
@matheusd matheusd changed the title [wip] [trezor] initial trezor support [trezor] initial trezor support Oct 30, 2018
@matheusd
Copy link
Member Author

Ready to start last round of tests for merging. Yay! 🎉

@matheusd
Copy link
Member Author

Rebased against latest master

@alexlyp
Copy link
Member

alexlyp commented Dec 3, 2018

tested and confirmed everything works as expected with Model T on testnet, going to start reviewing code now.

As discussed with @matheusd we will most likely hide this functionality behind a config setting until more issues are found/fixed and UX/UI is smoothed out.

alexlyp
alexlyp approved these changes Dec 3, 2018
View reviewed changes
Copy link
Member

@alexlyp alexlyp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work as usual!

@alexlyp alexlyp merged commit f5eacd4 into decred:master Dec 3, 2018
@matheusd matheusd deleted the trezor branch December 12, 2018 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexlyp alexlyp alexlyp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matheusd @alexlyp